CI: Fix regression test not using main branch code #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-krishna
changed the title
olejandro
approved these changes
Nov 22, 2024
|
Wow! This was an extensive investigative work. Thanks @siddharth-krishna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @olejandro in #240 (comment), the CI's regression test seems to not be working, reporting 0 changes even when there should be.
The bug was introduced in 0cb35dc which installed
xl2timesin CI using the built wheel instead of using the editable install, in order to test that the built package works. Unfortunately, this means that when the regression tester switches to the main branch, it still uses the code from the built package, instead of the main branch.This PR fixes it by testing the built package, and then reinstalling it in an editable way, so that the regression tests uses whatever code is in the folder.
To check that the regression tests work again, I introduced an intentional regression on this PR's branch, and checked that the regressions are caught in: ce8c853
To check that no regressions were introduced in
mainin the meantime, I ran the tests on the commit before the bug was introduced, c000f23, and compared it to the results on the latest commit 4ddec68: