-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend application of defaults beyond FI_T tables #240
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
71b8491
Move _populate_defaults out of apply_fixups
olejandro b3f5105
Create fill_defaults_in_transform_tables
olejandro 3eea791
Include fill_defaults_in_transform_tables in __main__.py
olejandro eca92eb
Extend the list of transform tables
olejandro b4f75e9
Refactor some parts to expose the logic
olejandro a5dfea8
Merge branch 'main' into olex/extend-defaults
olejandro b0864dc
Explode other_indexes as well
olejandro 1a20d34
Merge branch 'main' into olex/extend-defaults
olejandro 66aece7
Move veda_cgs calculation to model property
olejandro aa6dc26
Extend _populate_calculated_defaults to tfm tables
olejandro ab05a4d
Move things around
olejandro ea6f02f
Move things around again
olejandro 1006245
Clean-up
olejandro b14fbbe
Make minor fixes
olejandro 64b1240
Merge branch 'main' into olex/extend-defaults
siddharth-krishna 5e9db3e
Merge branch 'main' into olex/extend-defaults
olejandro 9829090
Merge branch 'main' into olex/extend-defaults
olejandro 64e3c25
Merge branch 'main' into olex/extend-defaults
olejandro 59a0eec
Eliminate additional rows
olejandro aea2790
Convert to string with a fixed float precision
siddharth-krishna 4ebadce
Merge branch 'main' into olex/extend-defaults
olejandro 7abfa93
Merge branch 'main' into olex/extend-defaults
olejandro ca46410
Fix naming post merge
olejandro 76a30ad
Query on limtype
olejandro 321aebd
Merge branch 'main' into olex/extend-defaults
olejandro 85c82ca
Address review comments
olejandro 691359e
Move around a comment
olejandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking: we don't expect this value to change when other properties/fields of the dataclass changes? Maybe we should add a TODO to check when this cached property is invalidated and have a way to clear the cache / recompute this. I'm wondering if that will be useful once we allow people to work with
TimesModel
objects directly in e.g. Jupyter Notebooks?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea!