Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle topology-only FI_T, and region and allregions in a TFM table #227

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Handle topology-only FI_T, and region and allregions in a TFM table #227

merged 7 commits into from
Mar 20, 2024

Conversation

olejandro
Copy link
Member

@olejandro olejandro commented Mar 18, 2024 •
edited
Loading

This PR allows handling the following situations:

  • no data columns in a FI_T table (i.e. topology info only)
  • both region and allregions columns present in a TFM table

@olejandro olejandro marked this pull request as ready for review March 19, 2024 20:52
@olejandro olejandro changed the title Allow FI_T only specifying topology Handle topology-only FI_T tables; allow region and allregions in a tfm table Mar 19, 2024
@olejandro olejandro changed the title Handle topology-only FI_T tables; allow region and allregions in a tfm table Handle topology-only FI_T, and region and allregions in a TFM table Mar 19, 2024
siddharth-krishna
siddharth-krishna approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just noticed a minor opportunity to optimize.

xl2times/transforms.py Outdated Show resolved Hide resolved
@olejandro olejandro merged commit cc91ca5 into main Mar 20, 2024
1 check passed
@olejandro olejandro deleted the olex/allow-top-only branch March 20, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth-krishna siddharth-krishna siddharth-krishna approved these changes

@SamRWest SamRWest Awaiting requested review from SamRWest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olejandro @siddharth-krishna