Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove white spaces from a list of wildcard patterns #219

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

olejandro
Copy link
Member

@olejandro olejandro commented Mar 15, 2024

This PR allows distinguishing a comma-separated list of patterns from a pattern that includes commas.
It also increases correct rows on TUSM from 72.1% to 93.4%.

@olejandro olejandro changed the title Remove white spaces from wildcard patterns Remove white spaces from a list of wildcard patterns Mar 15, 2024
Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting! Code looks good at a high level, but I'm not sure I follow the logic in detail. If you have time, it would be great to have a docstring on filter_by_pattern explaining the combined argument, and perhaps a unit test for create_regexp with an example demonstrating the white space removal and handling of comma separated values? Thanks

@olejandro
Copy link
Member Author

Very exciting! Code looks good at a high level, but I'm not sure I follow the logic in detail. If you have time, it would be great to have a docstring on filter_by_pattern explaining the combined argument, and perhaps a unit test for create_regexp with an example demonstrating the white space removal and handling of comma separated values? Thanks

Thanks! I've added a docstring. Will open an issue for the unit test.

@olejandro olejandro merged commit 02e73d8 into main Mar 15, 2024
1 check passed
@olejandro olejandro deleted the olex/wildcards branch March 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants