Introduce EmbeddedXlTable.defaults to store composite tag info #216
Conversation
| @@ -57,7 +57,7 @@ def remove_comment_rows( | |||
| result = [] | |||
|
|
|||
| for table in tables: | |||
| tag = datatypes.Tag(table.tag.split(":")[0]) | |||
| tag = datatypes.Tag(table.tag) | |||
There was a problem hiding this comment.
Random nitpickey suggestion : this file would be more readable if we did from .datatypes import Tag and changed all these to just Tag(table.tag).
Unless there's a good reason not to (like if there was another Tag class somewhere that needed distinguishing from)
Same with datatype.Config, EmbeddedXlTable and TimesModel references.
There was a problem hiding this comment.
I think this would make a lot of sense. If @siddharth-krishna agrees we could change all them in a separate PR?
There was a problem hiding this comment.
Nice idea, thanks, I opened an issue to track it: #220
Thanks! Basically, this just extracts the extra info that may be included with a tag (e.g. |
xl2times/utils.py
Outdated
| (newtag, varname) = table.tag.split(":") | ||
| varname = varname.strip() | ||
| if table.defaults: | ||
| varname = table.defaults | ||
| df = table.dataframe.copy() |
There was a problem hiding this comment.
I don't think we need the copy here btw
This PR introduces EmbeddedXlTable.defaults to store the additional info from a composite tag. Separating this info early on allows removing repeated decomposition of the composite tag.