Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow processing of the dins table and its variants #208

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

olejandro
Copy link
Member

No description provided.

@olejandro olejandro marked this pull request as ready for review March 5, 2024 21:32
@olejandro
Copy link
Member Author

@siddharth-krishna unfortunatelly none of the benchmarks allows testing this issue (unless we want to process multiple regions in TIM). I've confirmed that this improves the results on TUSM.

Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! If you have time, would it make sense to add a unit test for process_transform_table_variants or process_wildcards?

@olejandro
Copy link
Member Author

Good idea! :-) Let's maybe wait a little bit with it though. I am thinking we could refactor process_transform_table_variants to make use of utils.explode. @SamRWest has a branch working on optimising process_wildcards. I'll open an issue on how to simplify it and separate some logic.

@olejandro olejandro merged commit 36940b9 into main Mar 6, 2024
1 check passed
@olejandro olejandro deleted the olex/dins-processing branch March 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants