Use groupby to speed up user constraints #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, RTD is still not happy:
I had tried to manually add the webhooks, but RTD is still not able to report build status back to the GitHub PR as in this example: Perhaps it will still build a new docs site when this PR is merged into main? Let's see 🤞 |
|
The GitHub-RTD link is working in one direction, so even though the PR doesn't show it, RTD has built docs for this PR: |
|
Ok, so we merge this and keep #185 open as a reminder to make improvements in other parts of the code? |
olejandro
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I wanted to make a quick PR to test ReadTheDocs integration.)
This PR implements the suggestion from #185 on the code introduced by #179 (https://github.com/etsap-TIMES/xl2times/pull/179/files/4ea76267c9558b3a08d09ec282b7a5fcaa458f8c#r1489079776) and gets 3% runtime improvement on my laptop.