Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user-defined commodity groups #191

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Support user-defined commodity groups #191

merged 9 commits into from
Feb 22, 2024

Conversation

olejandro
Copy link
Member

Closes #187

@olejandro olejandro marked this pull request as ready for review February 21, 2024 21:46
siddharth-krishna
siddharth-krishna approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just a few minor suggestions.

xl2times/transforms.py Outdated Show resolved Hide resolved
xl2times/transforms.py Outdated Show resolved Hide resolved
xl2times/transforms.py Outdated Show resolved Hide resolved
xl2times/transforms.py Outdated Show resolved Hide resolved
xl2times/transforms.py Outdated Show resolved Hide resolved
xl2times/transforms.py Outdated Show resolved Hide resolved
@olejandro olejandro merged commit 1c35bcb into main Feb 22, 2024
1 check passed
@olejandro olejandro deleted the olex/read_ucgs branch February 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth-krishna siddharth-krishna siddharth-krishna approved these changes

@SamRWest SamRWest Awaiting requested review from SamRWest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support user-defined commodity groups
2 participants
@olejandro @siddharth-krishna