-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transforms speedup #186
Conversation
…d of subprocesses (which use way too much RAM) Added pyarrow to suppress pandas future warning
…nts in them work added traceable exit codes
…we're just missing a GAMS license.
skip gams install if no license
…ows' into feature/benchmarks_on_windows # Conflicts: # .gitignore # README.md
removed old looped function now vectorised outputs are verified as identical
…ows' into feature/benchmarks_on_windows
removed old looped function now vectorised outputs are verified as identical
…' into feature/transforms_speedup
Thanks @SamRWest, looks great! I left some minor comments. I guess, we'll need to merge the benchmarks PR first? |
It really depends. :-) Some of them could be additional, because casing is not the same as in the benchmarks - doesn't matter for GAMS; some need extra work - e.g. a dimension is inccorrect; some should have not been generated... |
@siddharth-krishna please go ahead merging if you don't have any further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Go ahead with the merge when ready.
fixed bug in git code when no remote is called 'origin'
Speeds up two slow parts of the
generate_commodity_groups
transform by replacing nested for loops with vectorised groupby calls.Also adds unit tests for the added functions and small test data files (from austimes) for verification.
Pytest runs and coverage reporting are now integrated into CI as well.
CSV-only regression test results show decent overall speedup:
But not sure whether the additional row metric increasing or decreasing is good, can you advise?
Update: full GAMS CI run here didn't show any change to correct/additional rows :)