Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of TIM used for benchmark #164

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

olejandro
Copy link
Member

No description provided.

@olejandro olejandro marked this pull request as ready for review January 19, 2024 04:28
@olejandro
Copy link
Member Author

@siddharth-krishna any chance you could help with passing regions for the Ireland model from benchmarks.yml down to the tool? 🙏 Without it the CI will take long time...

@siddharth-krishna
Copy link
Collaborator

siddharth-krishna commented Jan 19, 2024

Sure. Here is the result for the new Ireland model: (Note that both the main version and the branch version are the same since the repo has changed for both.)

      Ireland  101.9 103.3  Error: dd_… Error: dd_…   88.5  88.5  36296  36296  46664  46664

The old Ireland model result was:

Ireland              46.4  Error: dd_files not in benchmark        90.1      26605          1003

If those numbers look expected, we can merge this.

@olejandro
Copy link
Member Author

Super, thanks a lot! This version of TIM wasn't optimised for processing, so the result looks as expected.

@olejandro olejandro merged commit 57aca73 into main Jan 19, 2024
1 check passed
@olejandro olejandro deleted the olex/update-ie-benchmark branch January 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants