Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to distribute the tool on PyPI #149

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Prepare to distribute the tool on PyPI #149

merged 4 commits into from
Dec 12, 2023

Conversation

siddharth-krishna
Copy link
Collaborator

No description provided.

@siddharth-krishna
Copy link
Collaborator Author

Regression tests are failing because the name of the tool changed, so it can't find xl2times in the main branch to compare to. Perhaps I can compare the numbers manually and override the check for this PR when we're ready?

@olejandro
Copy link
Member

Sounds reasonable. :-) I review this once the vote is closed and we are sure about the name.

@@ -1,6 +1,6 @@
{
"include": [
"times_reader",
"xl2times",
"utils",
"times_excel_reader.py"
Copy link
Member

@olejandro olejandro Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should times_excel_reader.py be renamed as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we should remove that. It's a remnant of the previous folder structure, before we started using pyproject.toml and setuptools

@olejandro
Copy link
Member

@siddharth-krishna I've compared the numbers manually and it looks okay. I'll merge this so that we can move on.

@olejandro olejandro marked this pull request as ready for review December 12, 2023 16:23
@siddharth-krishna
Copy link
Collaborator Author

Give me a few minutes

@olejandro olejandro merged commit bb09247 into main Dec 12, 2023
1 check failed
@olejandro olejandro deleted the sidk/upload-pypi branch December 12, 2023 16:24
@olejandro
Copy link
Member

Sorry, was too fast. Did not know you were on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants