-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to distribute the tool on PyPI #149
Conversation
Regression tests are failing because the name of the tool changed, so it can't find |
Sounds reasonable. :-) I review this once the vote is closed and we are sure about the name. |
@@ -1,6 +1,6 @@ | |||
{ | |||
"include": [ | |||
"times_reader", | |||
"xl2times", | |||
"utils", | |||
"times_excel_reader.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should times_excel_reader.py
be renamed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we should remove that. It's a remnant of the previous folder structure, before we started using pyproject.toml
and setuptools
@siddharth-krishna I've compared the numbers manually and it looks okay. I'll merge this so that we can move on. |
Give me a few minutes |
Sorry, was too fast. Did not know you were on it! |
No description provided.