Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify normalisation #147

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Simplify normalisation #147

merged 4 commits into from
Dec 6, 2023

Conversation

olejandro
Copy link
Member

@olejandro olejandro commented Dec 3, 2023 •
edited
Loading

This PR:

  • restructures veda-tags.json
  • removes apply_postnormalisation_fixes
  • moves info on which tables can be discarded if empty to config

@olejandro
Copy link
Member Author

@siddharth-krishna please feel free to modify if you find necessary

@olejandro olejandro marked this pull request as ready for review December 3, 2023 06:17
siddharth-krishna
siddharth-krishna reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I pushed some minor edits.

Just one point: I'm curious why we have both a name field and a use_name field? Why not just make the name the canonical name for each column/field?

@olejandro
Copy link
Member Author

Just one point: I'm curious why we have both a name field and a use_name field? Why not just make the name the canonical name for each column/field?

Basically, as it is now, name represents the canonical name (determined by the source), while use-name is the name used in the tool (determined by us). We could change this in the future, but for now I believe it is good to keep the distinction.

@siddharth-krishna siddharth-krishna merged commit 8869a68 into main Dec 6, 2023
1 check passed
@siddharth-krishna siddharth-krishna deleted the olex/simplify-normalisation branch December 6, 2023 01:50
@olejandro olejandro mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth-krishna siddharth-krishna siddharth-krishna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olejandro @siddharth-krishna