Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for aliases when processing AT tables #144

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

olejandro
Copy link
Member

No description provided.

@olejandro olejandro marked this pull request as ready for review December 1, 2023 04:21
Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of accounting for aliases, should we normalize attribute aliases like we do for column names?

@olejandro
Copy link
Member Author

It is a bit difficult to normalise attribute aliases like we do for column names at that stage, because some of them require a special action or assigning a default value; we do that later on... In one of the next PR, I'll try to migrate some of that info from the code to the file.

Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good thanks.

@siddharth-krishna siddharth-krishna merged commit 073dd9f into main Dec 2, 2023
1 check passed
@siddharth-krishna siddharth-krishna deleted the olex/attr-aliases branch December 2, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants