-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aux flows to topology #129
Conversation
@siddharth-krishna this one has regression with respect to addtional rows, so still needs some work. |
Just a small question/comment about this alias matter: I wonder whether you take into account that there are both strict aliases and variants of parameters now included in the lists. For example, CF is not strictly an alias for NCAP_AF, because the default LimType for CF (alias UTILIZATION) is FX while it is UP for NCAP_AF (alias AF, AVAILABILITY). A few other examples are EFF, which is not a strict alias for ACT_EFF, but a variant which does not support specifying the CG in ACT_EFF at all, and COST, which is not a strict alias for IRE_PRICE, but a variant which does not support specifying the commodity or IE, and ENV_ACT, which is not strictly an alias for FLO_EMIS, but a variant which does not support specifying the source CG. |
Co-authored-by: Siddharth Krishna <[email protected]>
@Antti-L good point! Yes, we already include a dictionary that specifies (some of) those defaults (incl. whether it should be input or output commodity like for |
@siddharth-krishna there is one additional record on Ireland which I believe is okay to keep. :-) |
Sounds good. Let me think what's the best way to merge this PR with a failing check.. |
@siddharth-krishna I was thinking to temporarily change the repository settings to be able to do this (i.e. not to enforce restrictions for admins). |
Sounds good! |
This PR adds aux commodity flows to topology. It also expands the list of Veda aliases for TIMES attributes.