Skip to content

Commit

Permalink
remove shell=True in dd_to_csv run on non-windows OSes
Browse files Browse the repository at this point in the history
  • Loading branch information
SamRWest committed Feb 21, 2024
1 parent 33fb41f commit fcd11cd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 0 additions & 5 deletions tests/test_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,6 @@ def test_uc_wildcards(self):
dictionary = pickle.load(f)
df = df_in.copy()

# df_in = pd.read_parquet("tests/data/process_uc_wildcards_austimes_data.parquet")
# with open("tests/data/process_uc_wildcards_austimes_dict.pkl", "rb") as f:
# dictionary = pickle.load(f)
# df = df_in.query("region in ['ACT', 'NSW']")

t0 = datetime.now()

# optimised functions
Expand Down
3 changes: 2 additions & 1 deletion utils/run_benchmarks.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import argparse
import os
import re
import shutil
import subprocess
Expand Down Expand Up @@ -159,7 +160,7 @@ def run_benchmark(
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
text=True,
shell=True,
shell=True if os.name == "nt" else False,
)
if res.returncode != 0:
# Remove partial outputs
Expand Down

0 comments on commit fcd11cd

Please sign in to comment.