Minor cleanup

etsap-TIMES · Dec 5, 2023 · d83a2ee · d83a2ee
1 parent 4e7f43d
commit d83a2ee
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/times_reader/datatypes.py b/times_reader/datatypes.py
@@ -293,11 +293,11 @@ def to_tag(s: str) -> Tag:
 
         valid_column_names = {}
         row_comment_chars = {}
-        discard_if_empty = list()
+        discard_if_empty = []
 
         for tag_info in veda_tags_info:
+            tag_name = to_tag(tag_info["tag_name"])
             if "valid_fields" in tag_info:
-                tag_name = to_tag(tag_info["tag_name"])
                 discard_if_empty.append(tag_name)
 
                 valid_column_names[tag_name] = {}
@@ -320,10 +320,8 @@ def to_tag(s: str) -> Tag:
                             "row_ignore_symbol"
                         ]
 
-        # TODO: Account for differences in valid field names with base_tag
-        for tag_info in veda_tags_info:
+            # TODO: Account for differences in valid field names with base_tag
             if "base_tag" in tag_info:
-                tag_name = to_tag(tag_info["tag_name"])
                 base_tag = to_tag(tag_info["base_tag"])
                 if base_tag in valid_column_names:
                     valid_column_names[tag_name] = valid_column_names[base_tag]