Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading binary files/streams by adjusting encoding to match mode #76

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Fix reading binary files/streams by adjusting encoding to match mode #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e6f857
Chore: Add `.venv` to `.gitignore`
amotl Dec 13, 2023
4072661
Fix reading binary files/streams by adjusting `encoding` to match `mode`
amotl Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ celerybeat-schedule
.env

# virtualenv
.venv/
venv/
ENV/

Expand Down
5 changes: 5 additions & 0 deletions tap_spreadsheets_anywhere/format_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ def get_streamreader(uri, universal_newlines=True, newline='', open_mode='r', en
SCHEME_SEP = "://"
kwargs = kwarg_dispatch.get(uri.split(SCHEME_SEP, 1)[0], lambda: {})()

# When reading in binary mode, undefine `encoding`.
# Otherwise, `smart_open` will return a `TextIOWrapper` in `"r"` mode.
# However, reading binary streams needs a `BufferedReader`.
if "b" in open_mode:
encoding = None
streamreader = smart_open.open(uri, open_mode, newline=newline, errors='surrogateescape', encoding=encoding, **kwargs)

if not universal_newlines and isinstance(streamreader, StreamReader):
Expand Down