Change fork modules to not use dynamic imports with top-level await.

This seems to solve a bunch of compatibility issues I ran into, the ecosystem just isn't ready for top-level await. With package.json marked as not having side-effects, it seems this can be optimized properly (at least by vite, tested w/ SvelteKit). I verified this by building a SvelteKit app that uses lexical and searching for strings that would only be in the dev build, e.g. `should implement "importDOM"`.
etrepum · Mar 14, 2024 · c6bf94e · c6bf94e
1 parent 9717280
commit c6bf94e
Show file tree

Hide file tree

Showing 27 changed files with 56 additions and 26 deletions.
diff --git a/packages/lexical-clipboard/package.json b/packages/lexical-clipboard/package.json
@@ -25,5 +25,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-clipboard"
   },
-  "module": "LexicalClipboard.esm.js"
+  "module": "LexicalClipboard.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-code/package.json b/packages/lexical-code/package.json
@@ -25,5 +25,6 @@
   "devDependencies": {
     "@types/prismjs": "^1.26.0"
   },
-  "module": "LexicalCode.esm.js"
+  "module": "LexicalCode.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-dragon/package.json b/packages/lexical-dragon/package.json
@@ -19,5 +19,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-dragon"
   },
-  "module": "LexicalDragon.esm.js"
+  "module": "LexicalDragon.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-file/package.json b/packages/lexical-file/package.json
@@ -20,5 +20,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-file"
   },
-  "module": "LexicalFile.esm.js"
+  "module": "LexicalFile.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-hashtag/package.json b/packages/lexical-hashtag/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-hashtag"
   },
-  "module": "LexicalHashtag.esm.js"
+  "module": "LexicalHashtag.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-headless/package.json b/packages/lexical-headless/package.json
@@ -18,5 +18,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-headless"
   },
-  "module": "LexicalHeadless.esm.js"
+  "module": "LexicalHeadless.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-history/package.json b/packages/lexical-history/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-history"
   },
-  "module": "LexicalHistory.esm.js"
+  "module": "LexicalHistory.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-html/package.json b/packages/lexical-html/package.json
@@ -22,5 +22,6 @@
     "@lexical/selection": "0.13.1",
     "@lexical/utils": "0.13.1"
   },
-  "module": "LexicalHtml.esm.js"
+  "module": "LexicalHtml.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-link/package.json b/packages/lexical-link/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-link"
   },
-  "module": "LexicalLink.esm.js"
+  "module": "LexicalLink.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-list/package.json b/packages/lexical-list/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-list"
   },
-  "module": "LexicalList.esm.js"
+  "module": "LexicalList.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-mark/package.json b/packages/lexical-mark/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-mark"
   },
-  "module": "LexicalMark.esm.js"
+  "module": "LexicalMark.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-markdown/package.json b/packages/lexical-markdown/package.json
@@ -26,5 +26,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-markdown"
   },
-  "module": "LexicalMarkdown.esm.js"
+  "module": "LexicalMarkdown.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-offset/package.json b/packages/lexical-offset/package.json
@@ -18,5 +18,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-offset"
   },
-  "module": "LexicalOffset.esm.js"
+  "module": "LexicalOffset.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-overflow/package.json b/packages/lexical-overflow/package.json
@@ -18,5 +18,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-overflow"
   },
-  "module": "LexicalOverflow.esm.js"
+  "module": "LexicalOverflow.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-plain-text/package.json b/packages/lexical-plain-text/package.json
@@ -20,5 +20,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-plain-text"
   },
-  "module": "LexicalPlainText.esm.js"
+  "module": "LexicalPlainText.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-playground/package.json b/packages/lexical-playground/package.json
@@ -41,5 +41,6 @@
     "rollup-plugin-copy": "^3.5.0",
     "vite": "^2.9.16",
     "vite-plugin-replace": "0.1.1"
-  }
+  },
+  "sideEffects": false
 }
diff --git a/packages/lexical-react/package.json b/packages/lexical-react/package.json
@@ -600,5 +600,6 @@
       },
       "require": "./useLexicalTextEntity.js"
     }
-  }
+  },
+  "sideEffects": false
 }
diff --git a/packages/lexical-rich-text/package.json b/packages/lexical-rich-text/package.json
@@ -20,5 +20,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-rich-text"
   },
-  "module": "LexicalRichText.esm.js"
+  "module": "LexicalRichText.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-selection/package.json b/packages/lexical-selection/package.json
@@ -19,5 +19,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-selection"
   },
-  "module": "LexicalSelection.esm.js"
+  "module": "LexicalSelection.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-table/package.json b/packages/lexical-table/package.json
@@ -21,5 +21,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-table"
   },
-  "module": "LexicalTable.esm.js"
+  "module": "LexicalTable.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-text/package.json b/packages/lexical-text/package.json
@@ -19,5 +19,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-text"
   },
-  "module": "LexicalText.esm.js"
+  "module": "LexicalText.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-utils/package.json b/packages/lexical-utils/package.json
@@ -23,5 +23,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-utils"
   },
-  "module": "LexicalUtils.esm.js"
+  "module": "LexicalUtils.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical-yjs/package.json b/packages/lexical-yjs/package.json
@@ -25,5 +25,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical-yjs"
   },
-  "module": "LexicalYjs.esm.js"
+  "module": "LexicalYjs.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/lexical/package.json b/packages/lexical/package.json
@@ -16,5 +16,6 @@
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/lexical"
   },
-  "module": "Lexical.esm.js"
+  "module": "Lexical.esm.js",
+  "sideEffects": false
 }
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -16,5 +16,6 @@
     "type": "git",
     "url": "https://github.com/facebook/lexical",
     "directory": "packages/shared"
-  }
+  },
+  "sideEffects": false
 }
diff --git a/scripts/build.js b/scripts/build.js
@@ -619,7 +619,9 @@ function buildForkModule(outputPath, outputFileName, format, exports) {
   const prodFileName = `./${outputFileName}.prod${extension}`;
   if (format === 'esm') {
     lines.push(
-      `const mod = process.env.NODE_ENV === 'development' ? await import('${devFileName}') : await import('${prodFileName}');`,
+      `import * as modDev from '${devFileName}';`,
+      `import * as modProd from '${prodFileName}';`,
+      `const mod = process.env.NODE_ENV === 'development' ? modDev : modProd;`,
     );
     for (const name of exports) {
       lines.push(

diff --git a/scripts/updateVersion.js b/scripts/updateVersion.js
@@ -59,6 +59,9 @@ function withEsmExtension(fileName) {
 }
 
 function updateModule(packageJSON, pkg) {
+  if (packageJSON.sideEffects === undefined) {
+    packageJSON.sideEffects = false;
+  }
   if (packageJSON.main) {
     packageJSON.module = withEsmExtension(packageJSON.main);
   } else if (fs.existsSync(`./packages/${pkg}/dist`)) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -600,5 +600,6 @@ @@
           },
           "require": "./useLexicalTextEntity.js"
         }
-      }
+      },
+      "sideEffects": false
     }