forked from IABTechLab/fideslang
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Pydantic to version 2 #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-bump-pydantic-2
Migrated this over from the original PR here: IABTechLab#160! Check that out for additional history 👍 |
9 tasks
Closing in favor of #11. I needed to understand the V2 changes independently so I started a new branch and did a first pass, and now I'm comparing our branches and seeing what pieces I've missed. This work has been very helpful as well as code comments on IABTechLab#160. Thanks Thomas 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from IABTechLab#160
Closes #8
Description Of Changes
Pydantic 2 sees major changes that bring large performance advantages. Worth upgrading to stay up-to-date as well as enjoy downstream effects in increased performance
Pydantic 1 -> 2 Migration Guide: link
I fully expected we might need to tweak more things here based on testing against
Fides
directly, but we'll need to do more checks there to verify. Here is the corresponding Fides PRAs part of this migration, I adopted a very different general pattern for validation than we used before. Due to the major changes, I found it easier to use
model_validator
(formerly known asroot_validator
) and composed multiple validators together into a single, full-model validator instead of always using discrete validators by field.Code Changes
Pydantic
v2requirements.txt
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md