Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pydantic to version 2 #9

Closed
wants to merge 29 commits into from

Conversation

NevilleS
Copy link

@NevilleS NevilleS commented Jan 8, 2024

Migrated from IABTechLab#160

Closes #8

Description Of Changes

Pydantic 2 sees major changes that bring large performance advantages. Worth upgrading to stay up-to-date as well as enjoy downstream effects in increased performance

Pydantic 1 -> 2 Migration Guide: link

I fully expected we might need to tweak more things here based on testing against Fides directly, but we'll need to do more checks there to verify. Here is the corresponding Fides PR

As part of this migration, I adopted a very different general pattern for validation than we used before. Due to the major changes, I found it easier to use model_validator (formerly known as root_validator) and composed multiple validators together into a single, full-model validator instead of always using discrete validators by field.

Code Changes

  • make updates required for Pydantic v2
  • update the requirement bounds in requirements.txt
  • remove Python 3.8 from supported versions

Steps to Confirm

  • CI checks pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

ThomasLaPiana and others added 29 commits September 7, 2023 23:49
@NevilleS
Copy link
Author

NevilleS commented Jan 8, 2024

Migrated this over from the original PR here: IABTechLab#160! Check that out for additional history 👍

@pattisdr
Copy link

Closing in favor of #11. I needed to understand the V2 changes independently so I started a new branch and did a first pass, and now I'm comparing our branches and seeing what pieces I've missed. This work has been very helpful as well as code comments on IABTechLab#160. Thanks Thomas 🙏

@pattisdr pattisdr closed this Jun 16, 2024
@pattisdr pattisdr mentioned this pull request Jun 17, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants