Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing for stripe and hubspot #5584

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Improve testing for stripe and hubspot #5584

merged 15 commits into from
Dec 13, 2024

Conversation

Linker44
Copy link
Contributor

@Linker44 Linker44 commented Dec 9, 2024 •
edited by jira bot
Loading

Closes LA-173

Description Of Changes

Improve testing for stripe and hubspot.

Code Changes

  • list your code changes here
  • use connector runner for stripe
  • use connector runner for hubspot
  • create data for access and ereasure for stripe (must create at least two users and verify only one is returned)
  • create data for access and erasure for hubspot (must create at least two users and verify only one is returned)

Steps to Confirm

  1. CI checks are passing

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@Linker44 Linker44 self-assigned this Dec 9, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 7:57pm

@cypress Cypress
Copy link

cypress bot commented Dec 9, 2024 •
edited
Loading

fides    Run #11445

Run Properties:  status check passed Passed #11445  •  git commit bf90541a0a ℹ️: Merge 35eeb10c1b80d5e5a231b71d647f6923fa232419 into 9371f6f0b39cad1dd9d8e0a8ae58...
Project fides
Branch Review refs/pull/5584/merge
Run status status check passed Passed #11445
Run duration 00m 48s
Commit git commit bf90541a0a ℹ️: Merge 35eeb10c1b80d5e5a231b71d647f6923fa232419 into 9371f6f0b39cad1dd9d8e0a8ae58...
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@Linker44 Linker44 added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Dec 9, 2024
@Linker44 Linker44 marked this pull request as ready for review December 11, 2024 19:23
@Linker44 Linker44 requested a review from a team as a code owner December 11, 2024 19:23
@Linker44 Linker44 requested a review from Vagoasdf December 12, 2024 19:33
Vagoasdf
Vagoasdf approved these changes Dec 13, 2024
View reviewed changes
data/saas/dataset/hubspot_dataset.yml
masking_strategy_override:
strategy: random_string_rewrite
configuration:
format_preservation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! removing one override!

tests/fixtures/saas/stripe_fixtures.py
@@ -115,18 +118,326 @@ def stripe_dataset_config(
ctl_dataset.delete(db=db)


class StripeTestClient:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job refactoring these down to functions

@Linker44 Linker44 merged commit 6dbee02 into main Dec 13, 2024
38 of 40 checks passed
@Linker44 Linker44 deleted the improve_testing_for_stripe_and_hubspot branch December 13, 2024 15:16
@cypress Cypress
Copy link

cypress bot commented Dec 13, 2024

fides    Run #11472

Run Properties:  status check passed Passed #11472  •  git commit 6dbee0230a: Improve testing for stripe and hubspot (#5584)
Project fides
Branch Review main
Run status status check passed Passed #11472
Run duration 00m 41s
Commit git commit 6dbee0230a: Improve testing for stripe and hubspot (#5584)
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vagoasdf Vagoasdf Vagoasdf approved these changes

Assignees

@Linker44 Linker44

Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Linker44 @Vagoasdf