Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting dataset test results behind security flag #5573

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Putting dataset test results behind security flag #5573

merged 5 commits into from
Dec 9, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 6, 2024 •
edited
Loading

Closes LA-198

Description Of Changes

Adding the dsr_testing_tools_enabled security setting and using it to guard two endpoints:

  • POST /api/v1/connection/{connection_key}/dataset/{fides_key}/test
  • POST /api/v1/privacy-request/{privacy_request_id}/filtered-results

Steps to Confirm

  1. Set FIDES__SECURITY__DSR_TESTING_TOOLS_ENABLED to False
  2. Start Fides
  3. Attempt to run a test, you should see an error toast with the message "DSR testing tools are not enabled."
image The user will still be able to use the dataset editor and reachability status checker since they don't involve any user data.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:58pm

eastandwestwind
eastandwestwind approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding tests too!

@cypress Cypress
Copy link

cypress bot commented Dec 6, 2024 •
edited
Loading

fides    Run #11374

Run Properties:  status check passed Passed #11374  •  git commit 1b7e5d0458 ℹ️: Merge dda407769dff39f311222cfa2e6a0f8e09949b96 into 5600b5e65f9de2587e20ba5fa236...
Project fides
Branch Review refs/pull/5573/merge
Run status status check passed Passed #11374
Run duration 00m 48s
Commit git commit 1b7e5d0458 ℹ️: Merge dda407769dff39f311222cfa2e6a0f8e09949b96 into 5600b5e65f9de2587e20ba5fa236...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

eastandwestwind
eastandwestwind requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 nit, but otherwise looks good!

src/fides/api/api/v1/endpoints/privacy_request_endpoints.py Show resolved Hide resolved
@galvana galvana merged commit 8610b3f into main Dec 9, 2024
14 checks passed
@galvana galvana deleted the LA-198-put-dataset-test-results-behind-security-flag branch December 9, 2024 22:59
@cypress Cypress
Copy link

cypress bot commented Dec 9, 2024

fides    Run #11375

Run Properties:  status check passed Passed #11375  •  git commit 8610b3f705: Putting dataset test results behind security flag (#5573)
Project fides
Branch Review main
Run status status check passed Passed #11375
Run duration 00m 49s
Commit git commit 8610b3f705: Putting dataset test results behind security flag (#5573)
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

eastandwestwind pushed a commit that referenced this pull request Dec 10, 2024
@galvana @eastandwestwind
Putting dataset test results behind security flag (#5573)
faf7689
andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024
@galvana @andres-torres-marroquin
Putting dataset test results behind security flag (#5573)
b13e2c4
eastandwestwind pushed a commit that referenced this pull request Dec 11, 2024
@galvana @eastandwestwind
Putting dataset test results behind security flag (#5573)
ca48bae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @eastandwestwind