Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hj-298 - Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_systems test #5570

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #Hj-298

Description Of Changes

Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_systems test

Code Changes

  • Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_systems test

Steps to Confirm

  1. Run the test locally, or check the CI

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Dec 6, 2024 3:53pm

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, assuming CI passes 👍

@andres-torres-marroquin andres-torres-marroquin merged commit bd7bd4b into main Dec 6, 2024
18 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-298 branch December 6, 2024 16:08
Copy link

cypress bot commented Dec 6, 2024

fides    Run #11320

Run Properties:  status check passed Passed #11320  •  git commit 209b2e0f8c ℹ️: Merge 11c782d5f7df29cfd93b829a4fb1d28db460b409 into ca8e8470f38218fd95d448e1cf64...
Project fides
Branch Review refs/pull/5570/merge
Run status status check passed Passed #11320
Run duration 00m 39s
Commit git commit 209b2e0f8c ℹ️: Merge 11c782d5f7df29cfd93b829a4fb1d28db460b409 into ca8e8470f38218fd95d448e1cf64...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 6, 2024
Copy link

cypress bot commented Dec 6, 2024

fides    Run #11322

Run Properties:  status check passed Passed #11322  •  git commit bd7bd4bfcc: Hj-298 - Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_sys...
Project fides
Branch Review main
Run status status check passed Passed #11322
Run duration 00m 47s
Commit git commit bd7bd4bfcc: Hj-298 - Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_sys...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants