-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hj-298 - Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_systems test #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deleted_systems test
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
adamsachs
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, assuming CI passes 👍
fides Run #11320
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5570/merge
|
Run status |
Passed #11320
|
Run duration | 00m 39s |
Commit |
209b2e0f8c ℹ️: Merge 11c782d5f7df29cfd93b829a4fb1d28db460b409 into ca8e8470f38218fd95d448e1cf64...
|
Committer | Andres Torres |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
andres-torres-marroquin
added a commit
that referenced
this pull request
Dec 6, 2024
…deleted_systems test (#5570)
fides Run #11322
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11322
|
Run duration | 00m 47s |
Commit |
bd7bd4bfcc: Hj-298 - Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_sys...
|
Committer | Andres Torres |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
andres-torres-marroquin
added a commit
that referenced
this pull request
Dec 11, 2024
…deleted_systems test (#5570)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #Hj-298
Description Of Changes
Fix tests/ctl/core/test_api.py::TestSystemList::test_vendor_deleted_systems test
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works