Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

La 164 checking oauth access token regeneration #5548

Merged
merged 7 commits into from
Dec 6, 2024
Merged

La 164 checking oauth access token regeneration #5548

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fb687c
Adding check for client credential authorization strategy
Vagoasdf Nov 27, 2024
61db350
Adding Logs to record behaviour
Vagoasdf Nov 27, 2024
e83a24e
Revert "Adding Logs to record behaviour"
Vagoasdf Dec 5, 2024
36a02af
Removing unnecesary comment
Vagoasdf Dec 5, 2024
773f75e
Updated changelog
Vagoasdf Dec 5, 2024
5ca7eb0
Update CHANGELOG.md
Vagoasdf Dec 6, 2024
657c940
Merge branch 'main' into LA-164-Checking-Oauth-Access-token-regeneration
Vagoasdf Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ The types of changes are:
## [Unreleased](https://github.com/ethyca/fides/compare/2.51.0...main)



### Fixed
- saas connections based on `oauth_client_credentials` are properly updating their access token when we edit their secrets.
Vagoasdf marked this conversation as resolved.
Show resolved Hide resolved


## [2.51.0](https://github.com/ethyca/fides/compare/2.50.0...2.51.0)
Expand Down
4 changes: 2 additions & 2 deletions src/fides/api/models/connectionconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,10 @@ def authorized(self) -> bool:
return False

# hard-coding to avoid cyclic dependency
if authentication.strategy != "oauth2_authorization_code":
if authentication.strategy not in ["oauth2_authorization_code", "oauth2_client_credentials"]:
return False

return bool(self.secrets and self.secrets.get("access_token"))
return bool(self.secrets and 'access_token' in self.secrets.keys())

@property
def name_or_key(self) -> str:
Expand Down
Loading