-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HJ-128 - FE&BE: Datamap export should only include the visible columns of the report #5543
Open
andres-torres-marroquin
wants to merge
16
commits into
main
Choose a base branch
from
andres/HJ-128
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides Run #11473
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5543/merge
|
Run status |
Failed #11473
|
Run duration | 00m 59s |
Commit |
17a8700436 ℹ️: Merge 84bd2afdaedc6e1ef4ec5886e09bdc8017d9a05f into 6dbee0230acc4f81df580f28c0ac...
|
Committer | Andres Torres |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Tests for review
…e report in the defined order
andres-torres-marroquin
changed the title
HJ-128 - Adding CustomReport.config.column_order field
HJ-117 - FE: Datamap export should only include the visible columns of the report
Dec 2, 2024
andres-torres-marroquin
changed the title
HJ-117 - FE: Datamap export should only include the visible columns of the report
HJ-128 - FE&BE: Datamap export should only include the visible columns of the report
Dec 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 388 388
Lines 23906 23915 +9
Branches 2585 2585
=======================================
+ Hits 20826 20834 +8
- Misses 2522 2524 +2
+ Partials 558 557 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-128
Description Of Changes
FE&BE changes for: Datamap export should only include the visible columns of the report
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works