Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-128 - FE&BE: Datamap export should only include the visible columns of the report #5543

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Nov 26, 2024

Closes #HJ-128

Description Of Changes

FE&BE changes for: Datamap export should only include the visible columns of the report

Code Changes

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:09pm

Copy link

cypress bot commented Nov 26, 2024

fides    Run #11473

Run Properties:  status check failed Failed #11473  •  git commit 17a8700436 ℹ️: Merge 84bd2afdaedc6e1ef4ec5886e09bdc8017d9a05f into 6dbee0230acc4f81df580f28c0ac...
Project fides
Branch Review refs/pull/5543/merge
Run status status check failed Failed #11473
Run duration 00m 59s
Commit git commit 17a8700436 ℹ️: Merge 84bd2afdaedc6e1ef4ec5886e09bdc8017d9a05f into 6dbee0230acc4f81df580f28c0ac...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

@andres-torres-marroquin andres-torres-marroquin changed the title HJ-128 - Adding CustomReport.config.column_order field HJ-117 - FE: Datamap export should only include the visible columns of the report Dec 2, 2024
@andres-torres-marroquin andres-torres-marroquin changed the title HJ-117 - FE: Datamap export should only include the visible columns of the report HJ-128 - FE&BE: Datamap export should only include the visible columns of the report Dec 9, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (7e1832c) to head (3781230).

Files with missing lines Patch % Lines
src/fides/api/schemas/custom_report.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5543   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         388      388           
  Lines       23906    23915    +9     
  Branches     2585     2585           
=======================================
+ Hits        20826    20834    +8     
- Misses       2522     2524    +2     
+ Partials      558      557    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant