Add additional error handling for fides_string override options
#4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4761 ↗︎
Details:
Review all test suite changes for PR #4325 ↗︎ |
||||||||||||||||||||
NevilleS
changed the title
fides_string override options
Kelsey-Ethyca
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Today, providing a
fides_stringwith an AC suffix throws a runtime error when decoding, which is just because #4308 is in review. In the short-term, I'd like to get the current version "forwards-compatible" with that solution by just discarding the AC suffix. Ideally I should have included this in #4314 👍Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md