Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fideslog #4109

Closed
wants to merge 9 commits into from
Closed

Remove Fideslog #4109

wants to merge 9 commits into from

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Sep 17, 2023

Closes #4039

Description Of Changes

This is no longer used and removing it will help simplify the codebase and various features, as well as reducing overall load for each request.

Code Changes

  • remove fideslog from the requirements
  • pull out all fideslog-related code
  • do a migration to remove related tables/columns (userregistration table)

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@ThomasLaPiana ThomasLaPiana self-assigned this Sep 17, 2023
@cypress
Copy link

cypress bot commented Sep 17, 2023

Passing run #4942 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge d8cdc0f into a57c06a...
Project: fides Commit: c68f8816fb ℹ️
Status: Passed Duration: 01:02 💡
Started: Nov 1, 2023 10:19 AM Ended: Nov 1, 2023 10:20 AM

Review all test suite changes for PR #4109 ↗︎

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (a57c06a) to head (d8cdc0f).
Report is 792 commits behind head on main.

Files with missing lines Patch % Lines
...de_implementations/authentication_strategy_heap.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4109      +/-   ##
==========================================
+ Coverage   87.72%   87.88%   +0.15%     
==========================================
  Files         335      329       -6     
  Lines       21160    20855     -305     
  Branches     2753     2723      -30     
==========================================
- Hits        18563    18328     -235     
+ Misses       2127     2067      -60     
+ Partials      470      460      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasLaPiana ThomasLaPiana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Oct 27, 2023
@ThomasLaPiana
Copy link
Contributor Author

ThomasLaPiana commented Oct 27, 2023

@NevilleS FYI, this still make sense to you? Who knew how much fideslog related code we had!

@NevilleS NevilleS closed this Nov 12, 2024
@ThomasLaPiana
Copy link
Contributor Author

The saga ends 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fideslog from the application
2 participants