Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fideslang Typing #3839

Merged
merged 31 commits into from
Sep 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
342cd4c
Fix Fideslang Typing
ThomasLaPiana Jul 20, 2023
f738bb7
fix: implicit exports causing mypy issues
ThomasLaPiana Jul 20, 2023
3e2bccf
fix: more mypy
ThomasLaPiana Jul 20, 2023
45afc28
Merge branch 'main' into ThomasLaPiana-fix-fideslang-types
ThomasLaPiana Jul 27, 2023
845e770
feat: fix more mypy issues
ThomasLaPiana Jul 27, 2023
a72c709
fix: more mypy issues
ThomasLaPiana Jul 27, 2023
4f04a36
fix: more mypy issues
ThomasLaPiana Jul 31, 2023
aeec902
fix: mypy
ThomasLaPiana Jul 31, 2023
db8eb1c
fix: static_checks
ThomasLaPiana Jul 31, 2023
8457985
Merge branch 'main' into ThomasLaPiana-fix-fideslang-types
ThomasLaPiana Aug 3, 2023
6e27666
fix: get_server_resource tests
ThomasLaPiana Aug 3, 2023
fb22e0e
fix: TestLoadDefaultTaxonomy tests
ThomasLaPiana Aug 3, 2023
69a3d8e
fix: lib tests
ThomasLaPiana Aug 3, 2023
3f81430
fix: privacy notice tests
ThomasLaPiana Aug 3, 2023
7a52269
fix: static checks
ThomasLaPiana Aug 3, 2023
b7f0b9c
fix: revert bad system_manager_oauth_util change
ThomasLaPiana Aug 3, 2023
672163b
fix: add explicit model parsing to `audit` code
ThomasLaPiana Aug 4, 2023
d140ea2
fix: db scanning
ThomasLaPiana Aug 4, 2023
b790acb
fix: cli init test
ThomasLaPiana Aug 4, 2023
030efe1
feat: refactor a test
ThomasLaPiana Aug 6, 2023
874500f
feat: add helpful assertion messages
ThomasLaPiana Aug 6, 2023
c69c72a
fix: type signature
ThomasLaPiana Aug 8, 2023
e0f2f0c
Merge branch 'main' into ThomasLaPiana-fix-fideslang-types
ThomasLaPiana Aug 8, 2023
a72383f
fix: pylint
ThomasLaPiana Aug 8, 2023
a42893f
Merge branch 'ThomasLaPiana-fix-fideslang-types' of https://github.co…
ThomasLaPiana Aug 8, 2023
3b5b3e2
fix: explicitly convert to Cookie models
ThomasLaPiana Aug 9, 2023
761b9fc
Merge branch 'main' into ThomasLaPiana-fix-fideslang-types
ThomasLaPiana Sep 16, 2023
4255114
fix: mypy
ThomasLaPiana Sep 16, 2023
0498dd2
fix: system scanning
ThomasLaPiana Sep 17, 2023
cb8f7d0
Merge branch 'main' into ThomasLaPiana-fix-fideslang-types
ThomasLaPiana Sep 21, 2023
b1e20ae
feat: address review comments and add a new Protocol
ThomasLaPiana Sep 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/fides/api/db/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ async def upsert_privacy_declarations(

async def upsert_cookies(
async_session: AsyncSession,
cookies: Optional[List[Dict]], # CookieSchema
cookies: List[Dict], # CookieSchema
ThomasLaPiana marked this conversation as resolved.
Show resolved Hide resolved
privacy_declaration: PrivacyDeclaration,
system: System,
) -> None:
Expand All @@ -148,9 +148,6 @@ async def upsert_cookies(
Remove any existing cookies that aren't specified here.
"""

if not cookies:
return

for cookie_data in cookies:
# Check if cookie exists for this name/system/privacy declaration
result = await async_session.execute(
Expand Down