Skip to content

Commit

Permalink
Add DeprecationWarnings to fidesctl (#1244)
Browse files Browse the repository at this point in the history
* Add `DeprecationWarnings` to fidesctl

* add a deprecation warning to the CLI

* remove analytics ID

* add a deprecation warning that gets logged on the server

* update changelog

* update changelog for final release

* Update src/fidesctl/api/main.py

Co-authored-by: Steve Murphy <[email protected]>

* Update src/fidesctl/cli/__init__.py

Co-authored-by: Steve Murphy <[email protected]>

Co-authored-by: Steve Murphy <[email protected]>
  • Loading branch information
ThomasLaPiana and SteveDMurphy authored Oct 6, 2022
1 parent 7aa67b8 commit f2403c9
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 7 deletions.
12 changes: 6 additions & 6 deletions .fides/fidesctl.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[database]
server="fidesctl-db"
user="postgres"
password="fidesctl"
port="5432"
db="fidesctl"
test_db="fidesctl_test"
server = "fidesctl-db"
user = "postgres"
password = "fidesctl"
port = "5432"
db = "fidesctl"
test_db = "fidesctl_test"

[logging]
level = "INFO"
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ The types of changes are:
* `Fixed` for any bug fixes.
* `Security` in case of vulnerabilities.

## [Unreleased](https://github.com/ethyca/fides/compare/1.9.1...main)
## [1.9.2](https://github.com/ethyca/fides/compare/1.9.2...main)

### Deprecated

* Added a deprecation warning for the entire package [#1244](https://github.com/ethyca/fides/pull/1244)

### Added

Expand Down Expand Up @@ -60,6 +64,7 @@ The types of changes are:
* Dataset fields table shows categories in the last column. [#1088](https://github.com/ethyca/fides/pull/1088)

### Docs

* Updated the footer links [#1130](https://github.com/ethyca/fides/pull/1130)

### Fixed
Expand Down
5 changes: 5 additions & 0 deletions src/fidesctl/api/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ async def setup_server() -> None:
)

log.bind(api_config=CONFIG.logging.json()).debug("Configuration options in use")

docs_link = "https://ethyca.github.io/fides/"
log.warning(
f"WARNING: 'Fidesctl' has been deprecated and replaced by a more robust 'Fides' tool, which includes existing 'fidesctl' functionality. Run `pip install ethyca-fides` to get the latest version of Fides and visit '{docs_link}' for up-to-date documentation.\n"
)
await configure_db(CONFIG.database.sync_database_uri)


Expand Down
5 changes: 5 additions & 0 deletions src/fidesctl/cli/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ def cli(ctx: click.Context, config_path: str, local: bool) -> None:
The parent group for the Fidesctl CLI.
"""

docs_link = "https://ethyca.github.io/fides/"
click.secho(
f"WARNING: 'Fidesctl' has been deprecated and replaced by a more robust 'Fides' tool, which includes existing 'fidesctl' functionality. Run `pip install ethyca-fides` to get the latest version of Fides and visit '{docs_link}' for up-to-date documentation.\n",
fg="red",
)
ctx.ensure_object(dict)
config = get_config(config_path)

Expand Down

0 comments on commit f2403c9

Please sign in to comment.