Skip to content

Commit

Permalink
Change the version exception to a warning (#477)
Browse files Browse the repository at this point in the history
* Change the version exception to a warning

* remove the failing test

Co-authored-by: ThomasLaPiana <[email protected]>
  • Loading branch information
ThomasLaPiana and ThomasLaPiana authored Apr 8, 2022
1 parent 95b70b8 commit 8d7f2fd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion fidesctl/src/fidesctl/cli/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def check_server(cli_version: str, server_url: str) -> None:
echo_red(
f"Mismatched versions!\nServer Version: {server_version}\nCLI Version: {cli_version}"
)
raise SystemExit(1)


def pretty_echo(dict_object: Dict, color: str = "white") -> None:
Expand Down
10 changes: 0 additions & 10 deletions fidesctl/tests/cli/test_cli_utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import importlib
from unittest.mock import patch

import pytest

import fidesctl.cli.utils as utils
Expand All @@ -11,10 +8,3 @@ def test_check_server_bad_ping():
"Check for an exception if the server isn't up."
with pytest.raises(SystemExit):
utils.check_server("foo", "http://fake_address:8080")


@pytest.mark.integration
def test_check_server_version_mismatch(test_config):
"Check for a warning message if there is a version mismatch."
with pytest.raises(SystemExit):
utils.check_server("0.0.1", test_config.cli.server_url)

0 comments on commit 8d7f2fd

Please sign in to comment.