Skip to content

Commit

Permalink
La 164 checking oauth access token regeneration (#5548)
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Galvan <[email protected]>
  • Loading branch information
Vagoasdf and galvana authored Dec 6, 2024
1 parent 05cf5ef commit 7abb307
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ The types of changes are:
### Added
- New page in the Cookie House sample app to demonstrate the use of embedding the FidesJS SDK on the page [#5564](https://github.com/ethyca/fides/pull/5564)


### Fixed
- SaaS integrations using `oauth_client_credentials` now properly update their access token when editing the secrets.

## [2.51.0](https://github.com/ethyca/fides/compare/2.50.0...2.51.0)

Expand Down
4 changes: 2 additions & 2 deletions src/fides/api/models/connectionconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,10 @@ def authorized(self) -> bool:
return False

# hard-coding to avoid cyclic dependency
if authentication.strategy != "oauth2_authorization_code":
if authentication.strategy not in ["oauth2_authorization_code", "oauth2_client_credentials"]:
return False

return bool(self.secrets and self.secrets.get("access_token"))
return bool(self.secrets and 'access_token' in self.secrets.keys())

@property
def name_or_key(self) -> str:
Expand Down

0 comments on commit 7abb307

Please sign in to comment.