fix: mypy

.github/workflows/backend_checks.yml

@@ -79,6 +79,7 @@ jobs:
           [
             "isort",
             "black",
+            "mypy",
             "pylint",
             "xenon",
             "check_install",

noxfiles/docker_nox.py

@@ -2,6 +2,7 @@
 from typing import Callable, Dict, List, Optional, Tuple
 
 import nox
+
 from constants_nox import (
     DEV_TAG_SUFFIX,
     IMAGE,

src/fides/api/alembic/migrations/versions/f17f92237383_disable_inactive_notices.py

@@ -13,7 +13,6 @@
 from sqlalchemy.engine import Connection, ResultProxy
 from sqlalchemy.sql.elements import TextClause
 
-
 # revision identifiers, used by Alembic.
 from fides.api.models.sql_models import DataUse
 

src/fides/api/api/v1/endpoints/privacy_experience_endpoints.py

@@ -67,20 +67,20 @@ def _filter_experiences_by_region_or_country(
     if not region:
         return experience_query
 
-    region: str = escape(region).replace("-", "_").lower()
-    country: str = region.split("_")[0]
+    formatted_region: str = escape(region).replace("-", "_").lower()
+    country: str = formatted_region.split("_")[0]
 
     overlay: Optional[
         PrivacyExperience
     ] = PrivacyExperience.get_experience_by_region_and_component(
-        db, region, ComponentType.overlay
+        db, formatted_region, ComponentType.overlay
     ) or PrivacyExperience.get_experience_by_region_and_component(
         db, country, ComponentType.overlay
     )
     privacy_center: Optional[
         PrivacyExperience
     ] = PrivacyExperience.get_experience_by_region_and_component(
-        db, region, ComponentType.privacy_center
+        db, formatted_region, ComponentType.privacy_center
     ) or PrivacyExperience.get_experience_by_region_and_component(
         db, country, ComponentType.privacy_center
     )

src/fides/core/evaluate.py

@@ -290,12 +290,13 @@ def evaluate_dataset_reference(
             dataset.fides_key,
         )
 
+        data_qualifier = str(dataset.data_qualifier) if dataset.data_qualifier else ""
         dataset_result_violations = evaluate_policy_rule(
             taxonomy=taxonomy,
             policy_rule=policy_rule,
             data_subjects=[str(x) for x in privacy_declaration.data_subjects],
             data_categories=[str(x) for x in dataset.data_categories],
-            data_qualifier=dataset.data_qualifier,
+            data_qualifier=data_qualifier,
             data_use=privacy_declaration.data_use,
             declaration_violation_message=dataset_violation_message,
         )
@@ -371,12 +372,17 @@ def evaluate_privacy_declaration(
         )
     )
 
+    data_qualifier = (
+        str(privacy_declaration.data_qualifier)
+        if privacy_declaration.data_qualifier
+        else ""
+    )
     declaration_result_violations = evaluate_policy_rule(
         taxonomy=taxonomy,
         policy_rule=policy_rule,
         data_subjects=[str(x) for x in privacy_declaration.data_subjects],
         data_categories=[str(x) for x in privacy_declaration.data_categories],
-        data_qualifier=privacy_declaration.data_qualifier,
+        data_qualifier=data_qualifier,
         data_use=privacy_declaration.data_use,
         declaration_violation_message=declaration_violation_message,
     )