feat(MSFDG): adapt AttackV2 and StepV2 functions in op-challenger2 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-challenger2-attackv2
…allenger2-attackv2
…to bill/op-challenger2-attackv2
…to bill/op-challenger2-attackv2
dajuguan
reviewed
Nov 23, 2024
| @@ -208,7 +202,7 @@ func detectFailedStep(game types.Game, action types.Action, correctTrace types.T | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get correct trace at position %v: %w", poststateClaim.Position, err) | |||
| } | |||
| validStep := correctValue == poststateClaim.Value | |||
| validStep := correctValue == (*poststateClaim.SubValues)[0] | |||
There was a problem hiding this comment.
If poststateClaim is attacked by the non-0 branch, it might not be (*poststateClaim.SubValues)[0]
|
|
||
| preState, proofData, oracleData, err := s.trace.GetStepData(ctx, game, claim, position) | ||
| if branch == game.MaxAttackBranch()-1 { | ||
| // If we are at the max attack branch, we need to step on the next branch |
There was a problem hiding this comment.
If we agree subValues in [0, maxAttackBranch-1], the max attack branch should be stepped. might be more clear?
There was a problem hiding this comment.
I couldn't find this code. Has it been modified?
|
Deprecated in #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt AttackV2 and StepV2 functions in op-challenger2
Tests