Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(MSFDG): add common datatypes #81

Merged
merged 4 commits into from
Nov 3, 2024
Merged

chore(MSFDG): add common datatypes #81

merged 4 commits into from
Nov 3, 2024

Conversation

dajuguan
Copy link

@dajuguan dajuguan commented Oct 31, 2024 •
edited
Loading

Description

This PR adds some common datatypes and methods used in game and DA.

Tests

go test ./...

@dajuguan dajuguan force-pushed the po/common-datatypes branch from a79cb3e to ff31977 Compare October 31, 2024 19:41
@dajuguan dajuguan requested review from JustXxx and qizhou October 31, 2024 19:41
@dajuguan dajuguan mentioned this pull request Oct 31, 2024
Open
9 tasks
@dajuguan dajuguan force-pushed the po/common-datatypes branch 2 times, most recently from 006e15e to 2d9293a Compare October 31, 2024 19:59
@dajuguan dajuguan force-pushed the po/common-datatypes branch from 2d9293a to 7217728 Compare October 31, 2024 20:04
@blockchaindevsh
Copy link
Collaborator

blockchaindevsh commented Nov 2, 2024 •
edited
Loading

Before actual review, I've a question about the overall process:

Looks like op-challenger2 is a snapshot of op-challenger, and changes are based on the snapshot.

How to merge future upstream changes of op-challenger into op-challenger2?

@blockchaindevsh blockchaindevsh mentioned this pull request Nov 2, 2024
Closed
@dajuguan
Copy link
Author

dajuguan commented Nov 2, 2024

Before actual review, I've a question about the overall process:

Looks like op-challenger2 is a snapshot of op-challenger, and changes are based on the snapshot.

How to merge future upstream changes of op-challenger into op-challenger2?

Following Qi's advice, currently, it's mainly for develop usage. If we want to merge future upstream changes of op-challenger into op-challenger2, we can do it manually by cp -r op-challenger/* op-challenger2 and do cherry-pick.

blockchaindevsh
blockchaindevsh approved these changes Nov 2, 2024
View reviewed changes
op-challenger2/cmd/main_test.go Show resolved Hide resolved
op-challenger2/config/config_test.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/types/types.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/agent.go Show resolved Hide resolved
op-challenger2/game/fault/types/types.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/solver/solver.go Show resolved Hide resolved
op-challenger2/game/fault/trace/asterisc/executor_test.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/types/position.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/types/types.go Outdated Show resolved Hide resolved
op-challenger2/game/fault/types/position.go Outdated Show resolved Hide resolved
blockchaindevsh

This comment was marked as resolved.

Sign in to view

@dajuguan dajuguan force-pushed the po/common-datatypes branch from 17a13a1 to d8e6ea0 Compare November 2, 2024 14:49
@dajuguan dajuguan force-pushed the po/common-datatypes branch from d8e6ea0 to 9aef5fb Compare November 2, 2024 15:02
@dajuguan dajuguan merged commit b79405a into develop Nov 3, 2024
2 checks passed
@dajuguan dajuguan deleted the po/common-datatypes branch November 3, 2024 03:22
@dajuguan dajuguan mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockchaindevsh blockchaindevsh blockchaindevsh requested changes

@JustXxx JustXxx JustXxx approved these changes

@qizhou qizhou Awaiting requested review from qizhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dajuguan @blockchaindevsh @JustXxx