Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eip2930 & dont override signature #99

Merged
merged 2 commits into from
Oct 9, 2023
Merged

feat: eip2930 & dont override signature #99

merged 2 commits into from
Oct 9, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Oct 9, 2023 •
edited
Loading

Description

  • added new config params eip2930 which enabled eip2930 on a given chain. Note: EIP2930 cannot be used in unsafeMode and on chains that don't support eip1559
  • fixed the issue with the signature overriding during estimation

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's test the eip2930 feature thoroughly and see what impact it has on gas.

@0xSulpiride 0xSulpiride merged commit 698b505 into master Oct 9, 2023
5 of 6 checks passed
@0xSulpiride 0xSulpiride deleted the eip2930 branch October 9, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r