Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic networks #93

Merged
merged 11 commits into from
Sep 21, 2023
Merged

feat: dynamic networks #93

merged 11 commits into from
Sep 21, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Sep 18, 2023 •
edited
Loading

Description

  • removed networks.ts
  • chainIds are fetched dynamically by calling eth_chainId on a respective rpc provider
  • updated p2p.md

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: dynamic networks feat: dynamic networks Sep 19, 2023
ch4r10t33r
ch4r10t33r approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch4r10t33r
Copy link
Member

@arddluma What is the solution for the pipeline failures?

@arddluma
Copy link
Member

@arddluma What is the solution for the pipeline failures?

it is safe to ignore. this is known issue of the github action used EndBug/version-check#158

@arddluma
Copy link
Member

@marie-fourier could you please update config.json.default ?

@0xSulpiride 0xSulpiride merged commit 27fa404 into master Sep 21, 2023
3 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the dynamic-networks branch September 21, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xSulpiride @ch4r10t33r @arddluma