-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config rpc #88
feat: config rpc #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check as it fails when running --testingMode
. Not sure if it is related to this endpoint tho.
✖ TypeError: Cannot read properties of undefined (reading 'minInclusionDenominator')
876f842
to
cd1b239
Compare
packages/api/src/app.ts
Outdated
case CustomRPCMethods.skandha_config: | ||
result = await skandhaApi.getConfig(); | ||
// skip hexlify for this particular rpc | ||
return res.status(200).send({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pls avoid hardcoding and move the http status codes and messages to a common constants file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Description
skandha_config
Sample request:
Response:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyFurther comments (optional)