Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary search gas limits #84

Merged
merged 5 commits into from
Sep 11, 2023
Merged

binary search gas limits #84

merged 5 commits into from
Sep 11, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Aug 30, 2023

Description

  • enabled binary search for verificationGasLimit
  • simulateHandleOp estimates callGasLimit better than the binary search, so I disabled it (it was proved by stackup too - https://www.stackup.sh/blog/estimating-callgaslimit-for-useroperations). Also estimating callGasLimit with the binary search does not work in unsafeMode
  • updated the tracer
  • updated the opcode validation as per the new test cases

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: binary search gas limits binary search gas limits Sep 4, 2023
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride merged commit 554fe6f into master Sep 11, 2023
@0xSulpiride 0xSulpiride deleted the binary-search branch September 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants