Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nonce check #232

Merged
merged 5 commits into from
Aug 22, 2024
Merged

feat: Nonce check #232

merged 5 commits into from
Aug 22, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Aug 13, 2024 •
edited
Loading

Description

  • feat: updated polygon gas oracle
  • feat: added nonce check in knownAccounts

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride requested a review from ch4r10t33r August 22, 2024 08:19
@0xSulpiride 0xSulpiride changed the title wip: Nonce check feat: Nonce check Aug 22, 2024
ch4r10t33r
ch4r10t33r approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need a similar function for EP7 in Skandha2?

@0xSulpiride
Copy link
Member Author

@ch4r10t33r yes, will create a PR for that

@0xSulpiride 0xSulpiride merged commit 922f879 into master Aug 22, 2024
3 of 5 checks passed
@0xSulpiride 0xSulpiride deleted the nonce-check branch August 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r