feat: contract based binary search for call gas limit estimate #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4r10t33r
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Thanks for submitting the PR @nikhilkumar1612 . I have a couple of minor comments.
Please wait for @0xSulpiride to complete his review and then address all of the comments together.
ch4r10t33r
changed the title
|
@nikhilkumar1612 Please update package.json to reflect the latest version number. |
0xSulpiride
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Hey @nikhilkumar1612 great job 🚀 I just have some comments.
Also how has this been tested? I'd suggest that you do some testing on sepolia testnet
And pls set up eslint in your IDE
packages/executor/src/services/EntryPointService/versions/0.0.7.ts
Outdated
Show resolved
Hide resolved
packages/executor/src/services/EntryPointService/versions/0.0.7.ts
Outdated
Show resolved
Hide resolved
0xSulpiride
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
@nikhilkumar1612 great job 🚀
I'll merge it and will update the version
8 tasks
0xSulpiride
added a commit
that referenced
this pull request
Jul 16, 2024
…#217) Co-authored-by: nikhilkumar1612 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyFurther comments (optional)