Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ancient8 oracle #185

Merged
merged 4 commits into from
May 15, 2024
Merged

fix ancient8 oracle #185

merged 4 commits into from
May 15, 2024

Conversation

0xSulpiride
Copy link
Member

Description

  • use eth_gasPrice as ancient8 gas oracle and use the old oracle as a fallback
  • bundler-spec-tests is failing because the new version of Geth (v14) broke tests, so switched to v13

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride requested a review from arddluma May 15, 2024 09:44
arddluma
arddluma approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xSulpiride 0xSulpiride merged commit 8a40615 into master May 15, 2024
2 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the ancient8 branch May 15, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xSulpiride @ch4r10t33r @arddluma