feat: Websocket & mempool archieve & userop status method #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSulpiride
changed the title
ch4r10t33r
requested changes
Apr 26, 2024
docs/eth_subscribe.md
Outdated
|
|
||
| ```json | ||
| { | ||
| "method": "eth_subscribe", |
There was a problem hiding this comment.
Should we rename this as skandha_susbcribe?
This is skandha specific endpoints, so let's prefix it with skandha_
packages/executor/src/interfaces.ts
Outdated
| @@ -164,6 +164,9 @@ export interface NetworkConfig { | |||
| entryPointForwarder: string; | |||
| // api auth key for echo: https://echo.chainbound.io/docs/usage/api-interface#authentication | |||
| echoAuthKey: string; | |||
| // keep submitted, reverted and cancelled userops in the mempool for this many seconds | |||
| // default: 24 hours | |||
| archieveDuration: number; | |||
| @@ -133,6 +163,7 @@ export class Skandha { | |||
| gasFeeInSimulation: this.networkConfig.gasFeeInSimulation, | |||
| userOpGasLimit: this.networkConfig.userOpGasLimit, | |||
| bundleGasLimit: this.networkConfig.bundleGasLimit, | |||
| archieveDuration: this.networkConfig.archieveDuration, | |||
| @@ -0,0 +1,3 @@ | |||
| export const MAX_MEMPOOL_USEROPS_PER_SENDER = 4; | |||
| export const THROTTLED_ENTITY_MEMPOOL_COUNT = 4; | |||
| export const ARCHIEVE_PURGE_INTERVAL = 5 * 60 * 1000; // 50 minutse | |||
packages/node/src/index.ts
Outdated
| @@ -139,6 +139,7 @@ export class BundlerNode { | |||
| port: nodeOptions.api.port, | |||
| host: nodeOptions.api.address, | |||
| cors: nodeOptions.api.cors, | |||
| websocket: nodeOptions.api.websocket, | |||
There was a problem hiding this comment.
What port are we choosing as websocket connections?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skandha_subscribeandskandha_unsubscribemethods to listen to pending userops and submitted useropsskandha_userOperationStatusendpoint to fetch status from the archieveeth_subscribeandskandha_userOperationStatusapi.wsandapi.wsPortTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyFurther comments (optional)