Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fastlane #174

Merged
merged 4 commits into from
Apr 26, 2024
Merged

feat: fastlane #174

merged 4 commits into from
Apr 26, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Apr 18, 2024

Description

  • integration with Fastlane's pfl_sendRawTransactionConditional endpoint
  • added a config param fastlaneValidators - an array of our trusted validators

Tested on Polygon: https://polygonscan.com/tx/0x6f9dd051290ee1858a6901658a45faa17e12c16b736fb596ca14177262737da0

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: fastlane fastlane Apr 19, 2024
@0xSulpiride 0xSulpiride changed the title fastlane feat: fastlane Apr 24, 2024
@0xSulpiride 0xSulpiride changed the base branch from master to release-1.5.5 April 26, 2024 08:19
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -293,6 +294,12 @@ export class Config {
)
);

config.fastlaneValidators = fromEnvVar(
"FASTLANE_VALIDATOR",
config.fastlaneValidators || bundlerDefaultConfigs.fastlaneValidators,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in theory will be used only during the testing phase, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct

@0xSulpiride 0xSulpiride merged commit da9024c into release-1.5.5 Apr 26, 2024
4 of 5 checks passed
@0xSulpiride 0xSulpiride deleted the fastlane branch April 26, 2024 09:03
@0xSulpiride 0xSulpiride mentioned this pull request Apr 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants