Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echo integration #170

Merged
merged 9 commits into from
Apr 1, 2024
Merged

Echo integration #170

merged 9 commits into from
Apr 1, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Mar 29, 2024 •
edited
Loading

Description

Tested on Mainnet: https://etherscan.io/tx/0x6d70815b33f78e477d792958cb76b0f5a04bd07598369ddc448cc3a9aa455461

image

The bundle hash is different than the tx hash, but I'm not sure if they should be identical. This isn't critical for the bundler anyway, because it listens for the UserOperationEvent on EntryPoint, not for a tx hash

  • feat: getUserOpByHash returns userop from mempool (without blockNumber, blockHash and transaction if userop is not submitted)

image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xSulpiride 0xSulpiride merged commit 0082b2b into master Apr 1, 2024
2 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the echo-integration branch April 1, 2024 12:50
@0xSulpiride 0xSulpiride mentioned this pull request Apr 24, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r