Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kolibri integration #160

Merged
merged 6 commits into from
Mar 15, 2024
Merged

feat: kolibri integration #160

merged 6 commits into from
Mar 15, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Mar 13, 2024

Description

  • feat: kolibri integration
  • feat: config param for optional kolibri auth key

Tested on Polygon (BEV endpoint: https://bev-relay.kolibr.io)
https://polygonscan.com/tx/0x25c6a0423158ba73e4d891b09c8724773b8fef307ff4bf3c7d620a94974bd267
https://polygonscan.com/tx/0xfcce72092e9c4ddef8bc9100e6401c7d4c694edf672bc6943e5293692445c15b
https://polygonscan.com/tx/0x5fc1f93cdcc233f8245d891072b7de9374f3790d32157bbc2fb001558224850e

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: kolibri integration feat: kolibri integration Mar 14, 2024
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you want to amend merkle to sendBundle as well (In the same same PR)?

@0xSulpiride
Copy link
Member Author

0xSulpiride commented Mar 15, 2024

Do you want to amend merkle to sendBundle as well (In the same same PR)?

because sendBundle is from a different API I think I'll need to rework Merkle integration completely, so I think it should be a separate PR

@ch4r10t33r
Copy link
Member

Do you want to amend merkle to sendBundle as well (In the same same PR)?

because sendBundle is from a different API I think I'll need to rework Merkle integration completely, so I think it should be a separate PR

Sounds good to me.

@0xSulpiride 0xSulpiride merged commit 3fadd76 into master Mar 15, 2024
2 of 3 checks passed
@0xSulpiride 0xSulpiride deleted the kolibri branch March 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants