feat: multiple executors #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4r10t33r
reviewed
Dec 15, 2023
| @@ -4,8 +4,9 @@ | |||
| "entryPoints": [ | |||
| "0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789" | |||
| ], | |||
| "relayer": "0xprivateKey", | |||
| "beneficiary": "0x690b9a9e9aa1c9db991c7721a92d351db4fac990", | |||
| "relayers": [ | |||
There was a problem hiding this comment.
Should we consider an option of using a seed phrase and specify the list of relayers as well?
| if (privKey.startsWith("0x")) { | ||
| wallets.push(new Wallet(privKey, provider)); | ||
| } else { | ||
| wallets.push(Wallet.fromMnemonic(privKey).connect(provider)); |
There was a problem hiding this comment.
Does this mean we can also use a mnemonic? If so we need to document that in README.md
There was a problem hiding this comment.
yes, we can use mnemonics. Added it in README
ch4r10t33r
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relayersconfig which accepts an array of private keys of relayersrelayerconfig for backwards compatiblitybeneficiaryconfig optional, if it's not set, a relayer will always be a beneficiaryTested on Mumbai with 2 relayers and 2 userops at once
https://mumbai.polygonscan.com/tx/0xced5180faa7ec629a37bfd2b008a8d139f0112ecb3e777694a3f0eb58ee557f0
https://mumbai.polygonscan.com/tx/0xe230ab3fde49e0348f5bdc34dfa72e3458ae052926510dfb90bd6b97783d69d4
When sent another userop and all relayers are busy:
After some time, when one of the relayers is released:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyFurther comments (optional)