feat: create configurable pvg markup #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4r10t33r
requested changes
Dec 11, 2023
packages/executor/src/modules/eth.ts
Outdated
| @@ -459,7 +459,7 @@ export class Eth { | |||
| ov.perUserOp + | |||
| ov.perUserOpWord * lengthInWord | |||
| ); | |||
| return ret; | |||
| return ret + this.config.pvgMarkup; | |||
There was a problem hiding this comment.
Shouldn't we add validation here to ensure the values are positive?
There was a problem hiding this comment.
ret is always positive and pvgMarkup is negative only when deliberately set to a negative value by a relayer, so I think validation is excessive
There was a problem hiding this comment.
I understand that this is possible only if set deliberately. I just want to ensure this doesn't cause an issue.
ch4r10t33r
approved these changes
Dec 12, 2023
packages/executor/src/modules/eth.ts
Outdated
| @@ -459,7 +459,7 @@ export class Eth { | |||
| ov.perUserOp + | |||
| ov.perUserOpWord * lengthInWord | |||
| ); | |||
| return ret; | |||
| return ret + this.config.pvgMarkup; | |||
There was a problem hiding this comment.
I understand that this is possible only if set deliberately. I just want to ensure this doesn't cause an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyFurther comments (optional)