Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix gas price oracle on some non-EIP1559 chains #128

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat: fix gas price oracle on some non-EIP1559 chains #128

merged 2 commits into from
Dec 6, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Dec 6, 2023 •
edited
Loading

Description

image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title Fix gas price oracle on Fuse feat: fix gas price oracle on some non-EIP1559 chains Dec 6, 2023
ch4r10t33r
ch4r10t33r approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to start adding tests soon. I'll create an issue.

@0xSulpiride 0xSulpiride merged commit 571749a into master Dec 6, 2023
4 of 6 checks passed
@0xSulpiride 0xSulpiride deleted the fix-gas-price branch December 6, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r