Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus #116

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Prometheus #116

merged 8 commits into from
Nov 13, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Nov 10, 2023 •
edited
Loading

Description

  • feat: prometheus integration
  • added three cli flags: --metrics.enable, --metrics.host, --metrics.port
  • --metrics.enable - enables metrics, disabled by default
  • --metrics.host - ip address of metrics server, "127.0.0.1" by default
  • --metrics.port - metrics server port, 8008 by default

image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arddluma
arddluma approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔥 LGTM

@0xSulpiride 0xSulpiride merged commit 79376dc into master Nov 13, 2023
2 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the prometheus branch November 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xSulpiride @ch4r10t33r @arddluma