Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report checksummer userop.sender & markup on gas price #113

Merged
merged 3 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"npmClient": "yarn",
"useWorkspaces": true,
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"stream": "true",
"command": {
"version": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "root",
"private": true,
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"engines": {
"node": ">=18.0.0"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/api/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "api",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "The API module of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down Expand Up @@ -35,12 +35,12 @@
"class-transformer": "0.5.1",
"class-validator": "0.14.0",
"ethers": "5.7.2",
"executor": "^1.0.17-alpha",
"executor": "^1.0.18-alpha",
"fastify": "4.14.1",
"pino": "8.11.0",
"pino-pretty": "10.0.0",
"reflect-metadata": "0.1.13",
"types": "^1.0.17-alpha"
"types": "^1.0.18-alpha"
},
"devDependencies": {
"@types/connect": "3.4.35"
Expand Down
12 changes: 6 additions & 6 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cli",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "> TODO: description",
"author": "zincoshine <[email protected]>",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down Expand Up @@ -38,14 +38,14 @@
"@libp2p/peer-id-factory": "2.0.1",
"@libp2p/prometheus-metrics": "1.1.3",
"@multiformats/multiaddr": "12.1.3",
"api": "^1.0.17-alpha",
"db": "^1.0.17-alpha",
"executor": "^1.0.17-alpha",
"api": "^1.0.18-alpha",
"db": "^1.0.18-alpha",
"executor": "^1.0.18-alpha",
"find-up": "5.0.0",
"got": "12.5.3",
"js-yaml": "4.1.0",
"node": "^1.0.17-alpha",
"types": "^1.0.17-alpha",
"node": "^1.0.18-alpha",
"types": "^1.0.18-alpha",
"yargs": "17.6.2"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/db/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "db",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "The DB module of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://github.com/etherspot/etherspot-bundler#readme",
Expand Down Expand Up @@ -33,7 +33,7 @@
"dependencies": {
"@chainsafe/ssz": "0.10.1",
"@farcaster/rocksdb": "5.5.0",
"types": "^1.0.17-alpha"
"types": "^1.0.18-alpha"
},
"devDependencies": {
"@types/rocksdb": "3.0.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/executor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "executor",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "The Relayer module of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down Expand Up @@ -33,7 +33,7 @@
"dependencies": {
"async-mutex": "0.4.0",
"ethers": "5.7.2",
"params": "^1.0.17-alpha",
"types": "^1.0.17-alpha"
"params": "^1.0.18-alpha",
"types": "^1.0.18-alpha"
}
}
6 changes: 4 additions & 2 deletions packages/executor/src/entities/MempoolEntry.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { BigNumber, BigNumberish, ethers } from "ethers";
import { hexValue } from "ethers/lib/utils";
import { getAddress, hexValue } from "ethers/lib/utils";
import * as RpcErrorCodes from "types/lib/api/errors/rpc-error-codes";
import RpcError from "types/lib/api/errors/rpc-error";
import { UserOperationStruct } from "types/lib/executor/contracts/EntryPoint";
Expand Down Expand Up @@ -111,6 +111,8 @@ export class MempoolEntry implements IMempoolEntry {

validateAndTransformUserOp(): void {
try {
this.userOp.sender = getAddress(this.userOp.sender);
this.entryPoint = getAddress(this.entryPoint);
this.prefund = BigNumber.from(this.prefund);
this.userOp.nonce = BigNumber.from(this.userOp.nonce);
this.userOp.callGasLimit = BigNumber.from(this.userOp.callGasLimit);
Expand All @@ -133,7 +135,7 @@ export class MempoolEntry implements IMempoolEntry {
return {
chainId: this.chainId,
userOp: {
sender: this.userOp.sender,
sender: getAddress(this.userOp.sender),
nonce: hexValue(this.userOp.nonce),
initCode: this.userOp.initCode,
callData: this.userOp.callData,
Expand Down
15 changes: 8 additions & 7 deletions packages/executor/src/executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,19 @@ export class Executor {
this.mempoolService,
this.reputationService
);
this.skandha = new Skandha(
this.networkName,
this.chainId,
this.provider,
this.config,
this.logger
);
this.eth = new Eth(
this.chainId,
this.provider,
this.userOpValidationService,
this.mempoolService,
this.skandha,
this.networkConfig,
this.logger,
this.nodeApi
Expand All @@ -121,13 +129,6 @@ export class Executor {
this.config,
this.logger
);
this.skandha = new Skandha(
this.networkName,
this.chainId,
this.provider,
this.config,
this.logger
);

if (this.config.testingMode || options.bundlingMode == "manual") {
this.bundlingService.setBundlingMode("manual");
Expand Down
18 changes: 5 additions & 13 deletions packages/executor/src/modules/eth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
EstimateUserOperationGasArgs,
SendUserOperationGasArgs,
} from "./interfaces";
import { Skandha } from "./skandha";

export class Eth {
private pvgEstimator: IPVGEstimator | null = null;
Expand All @@ -38,6 +39,7 @@ export class Eth {
private provider: ethers.providers.JsonRpcProvider,
private userOpValidationService: UserOpValidationService,
private mempoolService: MempoolService,
private skandhaModule: Skandha,
private config: NetworkConfig,
private logger: Logger,
private nodeApi?: INodeAPI
Expand Down Expand Up @@ -190,21 +192,11 @@ export class Eth {
callGasLimit,
};

const gasFee = await getGasFee(
this.chainId,
this.provider,
this.config.etherscanApiKey,
{
entryPoint,
userOp: userOpToEstimate,
}
);
const gasFee = await this.skandhaModule.getGasPrice();

if (this.pvgEstimator) {
userOpComplemented.maxFeePerGas =
gasFee.maxFeePerGas ?? gasFee.gasPrice ?? 1;
userOpComplemented.maxPriorityFeePerGas =
gasFee.maxPriorityFeePerGas ?? gasFee.gasPrice ?? 1;
userOpComplemented.maxFeePerGas = gasFee.maxFeePerGas;
userOpComplemented.maxPriorityFeePerGas = gasFee.maxPriorityFeePerGas;
preVerificationGas = await this.pvgEstimator(
ch4r10t33r marked this conversation as resolved.
Show resolved Hide resolved
entryPoint,
userOpComplemented,
Expand Down
3 changes: 1 addition & 2 deletions packages/executor/src/services/BundlingService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,7 @@ export class BundlingService {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { gasLimit, ...txWithoutGasLimit } = tx;
// some chains, like Bifrost, don't allow setting gasLimit in estimateGas
const estimatedGasLimit = await wallet.estimateGas(txWithoutGasLimit);
tx.gasLimit = estimatedGasLimit;
await wallet.estimateGas(txWithoutGasLimit);
ch4r10t33r marked this conversation as resolved.
Show resolved Hide resolved
} catch (err) {
this.logger.error(err);
for (const entry of entries) {
Expand Down
1 change: 1 addition & 0 deletions packages/executor/src/services/MempoolService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { IDbController } from "types/lib";
import RpcError from "types/lib/api/errors/rpc-error";
import * as RpcErrorCodes from "types/lib/api/errors/rpc-error-codes";
import { UserOperationStruct } from "types/lib/executor/contracts/EntryPoint";
import { getAddress } from "ethers/lib/utils";
import { getAddr, now } from "../utils";
import { MempoolEntry } from "../entities/MempoolEntry";
import { IMempoolEntry, MempoolEntrySerialized } from "../entities/interfaces";
Expand Down
14 changes: 7 additions & 7 deletions packages/node/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "The bundler node module of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down Expand Up @@ -56,24 +56,24 @@
"@libp2p/tcp": "6.1.0",
"@multiformats/multiaddr": "11.4.0",
"abstract-leveldown": "7.2.0",
"api": "^1.0.17-alpha",
"api": "^1.0.18-alpha",
"datastore-core": "8.0.1",
"db": "^1.0.17-alpha",
"db": "^1.0.18-alpha",
"ethers": "5.7.2",
"executor": "^1.0.17-alpha",
"executor": "^1.0.18-alpha",
"it-filter": "1.0.2",
"it-map": "1.0.5",
"it-sort": "1.0.0",
"it-take": "1.0.1",
"libp2p": "0.42.2",
"params": "^1.0.17-alpha",
"params": "^1.0.18-alpha",
"prettier": "2.8.4",
"snappy": "7.2.2",
"snappyjs": "0.7.0",
"stream-to-it": "0.2.4",
"strict-event-emitter-types": "2.0.0",
"types": "^1.0.17-alpha",
"utils": "^1.0.17-alpha",
"types": "^1.0.18-alpha",
"utils": "^1.0.18-alpha",
"varint": "6.0.0",
"xxhash-wasm": "1.0.2"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/params/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "params",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "Various bundler parameters",
"author": "Etherspot",
"homepage": "https://github.com/etherspot/skandha#readme",
Expand All @@ -26,8 +26,8 @@
"@eth-optimism/sdk": "3.0.0",
"@mantleio/sdk": "0.2.1",
"ethers": "5.7.2",
"types": "^1.0.17-alpha",
"utils": "^1.0.17-alpha"
"types": "^1.0.18-alpha",
"utils": "^1.0.18-alpha"
},
"scripts": {
"clean": "rm -rf lib && rm -f *.tsbuildinfo",
Expand Down
7 changes: 4 additions & 3 deletions packages/params/src/utils/userOp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Bytes32, UintBn256 } from "types/lib/primitive/sszTypes";
import { fromHex, toHex } from "utils/lib";
import { BigNumber, BigNumberish } from "ethers";
import { UserOperationStruct } from "types/lib/executor/contracts/EntryPoint";
import { getAddress } from "ethers/lib/utils";

const bigintToBigNumber = (bn: bigint): BigNumberish => {
return BigNumber.from(UintBn256.fromJson(bn) as unknown as string);
Expand All @@ -23,7 +24,7 @@ export const userOpHashToString = (hash: ts.Bytes32): string => {
// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
export const deserializeUserOp = (userOp: ts.UserOp) => {
const dUserOp = {
sender: toHex(userOp.sender),
sender: getAddress(toHex(userOp.sender)),
nonce: bigintToBigNumber(userOp.nonce),
initCode: toHex(userOp.initCode),
callData: toHex(userOp.callData),
Expand Down Expand Up @@ -59,7 +60,7 @@ export const deserializeUserOpsWithEP = (

export const serializeUserOp = (userOp: UserOperationStruct): ts.UserOp => {
return {
sender: fromHex(userOp.sender),
sender: fromHex(getAddress(userOp.sender)),
nonce: bigNumberishToBigint(userOp.nonce),
initCode: fromHex(userOp.initCode.toString()),
callData: fromHex(userOp.callData.toString()),
Expand All @@ -80,7 +81,7 @@ export const toUserOpsWithEP = (
blockHash: string
): ts.UserOpsWithEntryPoint => {
return {
entry_point_contract: fromHex(entryPoint),
entry_point_contract: fromHex(getAddress(entryPoint)),
chain_id: bigNumberishToBigint(chainId),
user_operations: userOps.map((userOp) => serializeUserOp(userOp)),
verified_at_block_hash: bigNumberishToBigint(blockHash),
Expand Down
3 changes: 3 additions & 0 deletions packages/params/src/whitelisted-entities/paymasters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,7 @@ export const WhitelistedPaymasters: IWhitelistedEntity = {
// USDC/ETH
getAddress("0x8b067387ec0B922483Eadb771bc9290194685522"),
],

// Mantle testnet
5001: [getAddress("0x6Ea25cbb60360243E871dD935225A293a78704a8")],
};
2 changes: 1 addition & 1 deletion packages/types/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "types",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "The types of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down
4 changes: 2 additions & 2 deletions packages/utils/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "utils",
"version": "1.0.17-alpha",
"version": "1.0.18-alpha",
"description": "utils of Etherspot bundler client",
"author": "Etherspot",
"homepage": "https://https://github.com/etherspot/skandha#readme",
Expand Down Expand Up @@ -37,6 +37,6 @@
"case": "^1.6.3",
"pino": "8.11.0",
"pino-pretty": "10.0.0",
"types": "^1.0.17-alpha"
"types": "^1.0.18-alpha"
}
}
Loading