Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bifrost gas estimation #110

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: bifrost gas estimation #110

merged 3 commits into from
Oct 30, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Oct 30, 2023 •
edited
Loading

Description

  • apparently in Bifrost there's a limit on gasLimit that can be set in eth_estimateGas (around 200k), that's why it didn't work on bigger userops and sponsored userops

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride requested a review from arddluma October 30, 2023 12:28
@arddluma arddluma requested a review from ch4r10t33r October 30, 2023 12:30
@arddluma arddluma changed the title fix bifrost gas estimation fix: bifrost gas estimation Oct 30, 2023
arddluma
arddluma approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xSulpiride 0xSulpiride merged commit 292c609 into master Oct 30, 2023
3 of 5 checks passed
@0xSulpiride 0xSulpiride deleted the bifrost-fix branch October 30, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r Awaiting requested review from ch4r10t33r

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @arddluma